Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel added #63

Closed
wants to merge 1 commit into from
Closed

Conversation

r6654kumar
Copy link

I have added a React Carousel to the UI which makes it look more attractive.
Please have a look at it and if you like it merge my PR.

Please put the GSSOC 24 tag.

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 7:35am
spring-music-player-3hyj ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 7:35am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @r6654kumar! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Owner

@Satyam1923 Satyam1923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some procedure that you need to follow don't just raise an PR without raising any issue. I liked your idea but you should follow curtain sets of rules and regulations. We are switching towards a new design so change is irrelevant.

function CarouselImage() {
return (
<Carousel data-bs-theme="dark">
<Carousel.Item>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use any url from the web.

@Satyam1923 Satyam1923 closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants