Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated recently played tile ui #445

Merged
merged 8 commits into from
Jul 6, 2024
Merged

Conversation

rohit-yadavv
Copy link
Contributor

Description

  • This PR Fixes the ui of recently played tile

Fixes #436

image### Additional Context

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2024 3:26am

Copy link

vercel bot commented Jun 28, 2024

@rohit-yadavv is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @rohit-yadavv! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Satyam1923
Copy link
Owner

@rohit-yadavv could you reduce the size of tile it looks different than others.

Copy link
Contributor Author

@rohit-yadavv rohit-yadavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduced size of tile

@rohit-yadavv
Copy link
Contributor Author

image

@Satyam1923
Copy link
Owner

Satyam1923 commented Jun 30, 2024

@rohit-yadavv add one more layer of it.

@rohit-yadavv
Copy link
Contributor Author

image

@Satyam1923
Copy link
Owner

@rohit-yadavv would you like to work on showing real time recent played song with help of firebase?

@rohit-yadavv
Copy link
Contributor Author

@Satyam1923 yes, i would you like to work on showing real time recent played song with help of firebase?

@Satyam1923 can you mark its label as level3 as it would be a complex task

@Satyam1923
Copy link
Owner

@rohit-yadavv ya fine i'll mark it.

@Satyam1923 Satyam1923 added enhancement New feature or request level3 labels Jul 2, 2024
@Satyam1923
Copy link
Owner

Screenshot 2024-07-02 181406
Screenshot 2024-07-02 181354
firestore schema

@rohit-yadavv
Copy link
Contributor Author

rohit-yadavv commented Jul 3, 2024

@Satyam1923 done, now getting recently played songs from firebase

@rohit-yadavv
Copy link
Contributor Author

rohit-yadavv commented Jul 3, 2024

@Satyam1923 image

image

@rohit-yadavv
Copy link
Contributor Author

@Satyam1923 merge these pr now i think it is completed now

@rohit-yadavv
Copy link
Contributor Author

@Satyam1923 please update and merge the pr

@Satyam1923
Copy link
Owner

Screenshot 2024-07-05 172206
UI is breaking.

@Satyam1923
Copy link
Owner

@rohit-yadavv when we are clicking on recent played song it should also play that song.

@rohit-yadavv
Copy link
Contributor Author

rohit-yadavv commented Jul 6, 2024

@Satyam1923 ok i will implement this functionality of playing song when clicked

@Satyam1923 for ui breaking actually whole home page ui breaks so i want to fix ui of whole home page i have also created a issue for that #437 but you told someone else is working but it is been 3 weeks assign that to me i will fix whole page ui

@rohit-yadavv
Copy link
Contributor Author

@Satyam1923 fixed that now playing songs on click
screen-capture (1).webm

@Satyam1923 Satyam1923 merged commit 358fbce into Satyam1923:master Jul 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: UI of recently played tiles
2 participants