-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liked song page #297
Liked song page #297
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@dhruv8433 is attempting to deploy a commit to the satyam1923's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @dhruv8433! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We'd also like to invite you to our Discord server! Join us here.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
kindly please check this and merge it |
@dhruv8433 how should I test it out and using main page music player card. |
@dhruv8433 check deployed version it's not working. |
i don't have access of deployed version basically i created ui for liked song |
Spring.Mozilla.Firefox.2024-06-07.22-40-19.mp4 |
Spring.Mozilla.Firefox.2024-06-07.23-40-27.mp4see it's not working. |
now please check and inform me if it still not found... |
now you can merge it |
Now you can check this and merge it |
Please merge this |
please now you can check this and merge it |
Ok got it |
as you say i used musiccard component and update navbar repeated icon |
please check this and merge it so i can make new pr |
as you say i used musiccard component and update navbar repeated icon Please merge this so i can make another pr |
please check this and merge it |
now you can merge it |
Please merge this so i can make another pr |
Description
Feat: We can create seperate liked song pages #293
A clear and concise description of what the PR does.
/liked-song
Related Issues
Link any related issues using the format
Fixes #issue_number
.This helps to automatically close related issues when the PR is merged.
Changes
List the detailed changes made in this PR.
liked song
Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.
npm install
to install dependencies.npm test
to execute the test suite.Screenshots (if applicable)
Add any screenshots that help explain or visualize the changes.
Spring.Mozilla.Firefox.2024-06-07.21-22-42.mp4
Additional Context
Any additional context or information that reviewers should be aware of.
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.