Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liked song page #297

Merged
merged 22 commits into from
Jun 23, 2024
Merged

Liked song page #297

merged 22 commits into from
Jun 23, 2024

Conversation

dhruv8433
Copy link
Contributor

Description

Feat: We can create seperate liked song pages #293

A clear and concise description of what the PR does.

Related Issues

Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

Add any screenshots that help explain or visualize the changes.

Spring.Mozilla.Firefox.2024-06-07.21-22-42.mp4

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 11:04am
spring-music-player-3hyj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 11:04am

Copy link

vercel bot commented Jun 7, 2024

@dhruv8433 is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @dhruv8433! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jun 7, 2024

@Satyam1923

kindly please check this and merge it
and inform me if you want any modifications

@Satyam1923
Copy link
Owner

@dhruv8433 how should I test it out and using main page music player card.

@dhruv8433
Copy link
Contributor Author

@Satyam1923

clikc on liked icon in slide
image

@Satyam1923
Copy link
Owner

@dhruv8433 check deployed version it's not working.

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jun 7, 2024

@Satyam1923

i don't have access of deployed version

image

basically i created ui for liked song

@dhruv8433
Copy link
Contributor Author

@Satyam1923

Spring.Mozilla.Firefox.2024-06-07.22-40-19.mp4

@Satyam1923
Copy link
Owner

Satyam1923 commented Jun 7, 2024

Spring.Mozilla.Firefox.2024-06-07.23-40-27.mp4

see it's not working.

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jun 8, 2024

@Satyam1923

now please check and inform me if it still not found...
because in local it working properly and build is also success

image

@dhruv8433
Copy link
Contributor Author

@Satyam1923

now you can merge it
i resolve all deployment errors

@dhruv8433
Copy link
Contributor Author

@Satyam1923

Now you can check this and merge it

@dhruv8433
Copy link
Contributor Author

@Satyam1923

Please merge this

@Satyam1923
Copy link
Owner

Screenshot 2024-06-18 101712
errors.

@dhruv8433
Copy link
Contributor Author

@Satyam1923

please now you can check this and merge it

@Satyam1923
Copy link
Owner

Screenshot 2024-06-20 175810
use musicplayer component forthis which is already created.

@Satyam1923
Copy link
Owner

Screenshot 2024-06-20 175814
why mutlitple same things

@dhruv8433
Copy link
Contributor Author

Ok got it
I will complete it till night

@dhruv8433
Copy link
Contributor Author

@Satyam1923

image

as you say i used musiccard component and update navbar repeated icon

@dhruv8433
Copy link
Contributor Author

please check this and merge it so i can make new pr

@dhruv8433
Copy link
Contributor Author

dhruv8433 commented Jun 21, 2024

@Satyam1923

image

as you say i used musiccard component and update navbar repeated icon

Please merge this so i can make another pr

@dhruv8433
Copy link
Contributor Author

@Satyam1923

please check this and merge it

@Satyam1923
Copy link
Owner

Screenshot 2024-06-22 003251
heart and like both are same use any one of them.

@dhruv8433
Copy link
Contributor Author

@Satyam1923

image

now you can merge it

@dhruv8433
Copy link
Contributor Author

@Satyam1923

Please merge this so i can make another pr

@Satyam1923 Satyam1923 merged commit f6a9637 into Satyam1923:master Jun 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: We can create seperate liked song pages Feat: Improving the UI elements
2 participants