Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile #245

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Added Dockerfile #245

merged 3 commits into from
Jun 6, 2024

Conversation

Ratangulati
Copy link
Contributor

@Ratangulati Ratangulati commented Jun 3, 2024

Description

Created a dockerfile for both frontend and backend and updated the docs

Changes

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. cd frontend || backend
  3. Run docker build -t frontend:v1 . to create a docker image that will have frontend code. // It is a one time process
  4. Run docker run -p 3000:3000 frontend:v1 to run the docker image.
  5. Verify that ...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 0:39am
spring-music-player-3hyj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 0:39am

Copy link

vercel bot commented Jun 3, 2024

@Ratangulati is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Ratangulati! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Ratangulati
Copy link
Contributor Author

@Satyam1923 Please review the PR.
Thankyou

@Ratangulati
Copy link
Contributor Author

@Satyam1923 Can please add the gssoc and level tag for the PR?
It would be great if you have any feedback.

@Satyam1923 Satyam1923 added enhancement New feature or request gssoc level2 labels Jun 4, 2024
@Satyam1923 Satyam1923 merged commit 6dca645 into Satyam1923:master Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Dockerfile
2 participants