Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 404 not found page added with config #216 #229

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Feat: 404 not found page added with config #216 #229

merged 1 commit into from
Jun 4, 2024

Conversation

RamakrushnaBiswal
Copy link
Contributor

@RamakrushnaBiswal RamakrushnaBiswal commented Jun 1, 2024

Description

A clear and concise description of what the PR does.

  • This PR does the following:
    • Adds ... a 404.png image,PagenotFound.jsx and its CSS file
    • Fixes ... add the pages
    • Updates ...

Related Issues

issue #216
Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

  • Added a new feature to ...
  • Refactored the ...
  • Fixed a bug in ...

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

404.not.found.page.mp4

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 0:26am
spring-music-player-3hyj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 0:26am

Copy link

vercel bot commented Jun 1, 2024

@RamakrushnaBiswal is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @RamakrushnaBiswal! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@RamakrushnaBiswal
Copy link
Contributor Author

@Satyam1923 please review the PR

@Satyam1923
Copy link
Owner

@RamakrushnaBiswal how exactly I should test it out because currently it's showing not found page of vercel.

@RamakrushnaBiswal
Copy link
Contributor Author

hi @Satyam1923 here it is working
here i add a invalid URL it works
image

@Satyam1923
Copy link
Owner

@RamakrushnaBiswal fine.

@Satyam1923 Satyam1923 added good first issue Good for newcomers level2 gssoc enhancement New feature or request labels Jun 4, 2024
@Satyam1923 Satyam1923 merged commit 8c315a0 into Satyam1923:master Jun 4, 2024
5 checks passed
@RamakrushnaBiswal RamakrushnaBiswal deleted the ram-dev branch June 4, 2024 09:25
@RamakrushnaBiswal
Copy link
Contributor Author

Thank you sir @Satyam1923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Improving the UI elements
2 participants