Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #142 resolve #164

Closed

Conversation

AbhiSharma1511
Copy link

Description

This PR is for responsive and some modified UI also add feature of playing some or pause song

  • This PR does the following:
    • Adds ... Effect on playing and pausing song
    • Fixes ... Responsivness and change the aligment of the component
    • Updates ... UI

Related Issues

Link any related issues using the format Fixes #142.
This helps to automatically close related issues when the PR is merged.

Changes

List the detailed changes made in this PR.

  • Added a new feature to ... Play or pausing the effect
  • Refactored the ... Aligment of the component
  • Fixed a bug in ... responsivness

Screenshots (if applicable)

Before this PR:
Screenshot (127)

After this PR:

  1. Before search any song:
    Screenshot (131)

  2. After search any song:
    Screenshot (133)
    Screenshot (143)

  3. Responsivness:
    Screenshot (132)
    Screenshot (144)

Additional Context

Any additional context or information that reviewers should be aware of.

  • This PR is based on the following... Better UI and Responsivness of the application.
  • Please assign level3 under gssoc to this PR.

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • [ x] I have performed a self-review of my code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] My changes generate no new warnings
  • [ x] I am working on this issue under GSSOC

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 3:26pm
spring-music-player-3hyj ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 3:26pm

Copy link

vercel bot commented May 23, 2024

Someone is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @AbhiSharma1511! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@saurabhsingh720
Copy link
Contributor

@AbhiSharma1511
As we have given the figma design already.
@Satyam1923 review it.

@AbhiSharma1511
Copy link
Author

AbhiSharma1511 commented May 25, 2024 via email

@AbhiSharma1511
Copy link
Author

AbhiSharma1511 commented May 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsiveness
2 participants