Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage Requirement Completed #128

Closed
wants to merge 2 commits into from

Conversation

aanchalpahuja18
Copy link

image

Hello, I have completed the Homepage Feature which will beautify the website further and will improve the UI & UX. Kindly look at it once. Homepage feature includes a button of Get Started on clicking it will be directed to the main App.jsx component and from there the user will be able to Select & Play the songs.

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ❌ Failed (Inspect) May 24, 2024 5:28pm
spring-music-player-3hyj ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 5:28pm

Copy link

vercel bot commented May 17, 2024

@aanchalpahuja18 is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @aanchalpahuja18! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@aanchalpahuja18
Copy link
Author

@Satyam1923 & @riyasachdeva04 I have completed with the Homepage feature, Kindly review it once

@riyasachdeva04
Copy link

Please resolve the conflicts @aanchalpahuja18

@aanchalpahuja18
Copy link
Author

@riyasachdeva04 I have resolved all the conflicts. Kindly check once

@aanchalpahuja18
Copy link
Author

@riyasachdeva04 @Satyam1923 kindly check this once as I have made the homepage & fulfilled the requirement of it

@Satyam1923
Copy link
Owner

@aanchalpahuja18 firstly you are not even working with the design which was present earlier and now we have shifted to new design.
Secondly your app is still crashing not able to be properly deploy on vercel.
and you have taken a lot of time there I'll be closing this PR.

@Satyam1923 Satyam1923 closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants