Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌈✅Fixed and Enhanced Full Ui Design of this website According to Figma design. - #78 . 🚀 #127

Merged
merged 3 commits into from
May 17, 2024

Conversation

dhruv389
Copy link
Contributor

Description

solved Issue No : #78.

I have request to you Please convert this issue #78 To Level3 tag.

Overview

This pull request includes the following changes based on the provided Figma design:

  1. Background Changes: Updated the background color and style.
  2. Font Styles: Modified all font styles to match the Figma design.
  3. Images: Updated images as per the design requirements.
  4. Responsiveness: Improved the responsiveness at some level of the application across different devices (Need more improvements).
  5. Sidebar: Added a sidebar with navigation links.
  6. Icons: Incorporated new icons for better visual representation.
  7. Search Bar: Implemented a functional search bar that works according to the Figma design.

Screenshots

🚀 Before🚀

image

🌈 After✅✅

Spring.and.2.more.pages.-.Personal.-.Microsoft.Edge.2024-05-17.11-15-06.mp4

image

Type of Change

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
    -[X] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saurabhsingh720 Please review this Pull request and merge it.

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 5:16pm
spring-music-player-3hyj ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 5:16pm

Copy link

vercel bot commented May 17, 2024

@dhruv389 is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @dhruv389! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@saurabhsingh720 saurabhsingh720 merged commit 1323ea3 into Satyam1923:master May 17, 2024
2 of 3 checks passed
@saurabhsingh720
Copy link
Contributor

Responsiveness can be better as aspected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants