Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3157: Fix v6.0.0 plot scaling issues #3184

Open
wants to merge 6 commits into
base: release_6.0.1
Choose a base branch
from

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Jan 14, 2025

Description

This is a lesser implementation of the work already in #3148. This fixes the plot scaling issues introduced in v6.0.0, but doesn't make as clean a separation of the data and plots as I originally hoped to make for the release.

Refs #3021 (A start for this, but doesn't fully remove the x/y transforms from PlotterData classes and still uses them in a couple of places)
Fixes #3157

How Has This Been Tested?

Tested from source on Win11. Verified the following:

  • SAS data and fits are plotted together on log/log scale
  • SAS residuals are on log/lin scale
  • SESANS data and fits are plotted together on lin/lin scale
  • SESANS residuals are on lin/lin scale
  • All residual plots (SAS and SESANS) have the +/- 3 lines
  • Polydispersity plots are on lin/in scale
  • No change to 2D plot scaling

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@krzywon
Copy link
Contributor Author

krzywon commented Jan 14, 2025

MacOS builds failing due to notarization issue that is fixed in #3183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant