Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fitting widget refactor #3169

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fitting widget refactor #3169

wants to merge 5 commits into from

Conversation

rozyczko
Copy link
Member

@rozyczko rozyczko commented Jan 7, 2025

Description

This is the refactoring effort, the same as in #2651 but reparented to the current main.

  • Polydispersity widget logic moved to PolydispersityWidget.py
  • Polydispersity widget UI moved to PolydispersityWidgetUI.ui
  • Magnetic widget logic moved to MagnetismWidget.py
  • Magnetic widget UI moved to MagnetismWidgetUI.ui
  • Moved common structures to FittingLogic.py

All issues raised by @krzywon in the original PR have been addressed.

Additionally, the files involved in the refactor were "improved" by

  • adding type hints throughout
  • adding style changes required by ruff (running ruff check)

This is part 1 of the refactoring, focused on the two biggest and most independent components.
Next, I will attempt to refactor out constraints to a separate module.

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • [ X] There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • [X ] Windows installer (GH artifact) has been tested (installed and worked)
    • [X ] MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@rozyczko
Copy link
Member Author

rozyczko commented Jan 8, 2025

macos-latest fails due to a know issue with binary signing. #3134

@lucas-wilkins
Copy link
Contributor

@rozyczko - there's conflicts to resolve

@rozyczko rozyczko requested a review from krzywon January 9, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants