Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3109: Bumps v1.* compatibility fix #3165

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Jan 2, 2025

Description

This circumvents the fitting issue related to the recent changes in the bumps package that require parameter values to be floats, where SasView has been using uncertanties objects. The Parameter object has an optional attribute called slot introduced in v1.* that I am using here instead. This attribute does not exist in v0.9.3 of bumps, but the way I am using it creates a new attribute of the parameter, maintaining backward compatibility.

Fixes #3109

How Has This Been Tested?

Tested locally using both bumps v0.9.3 and v1.0.0a10. Fits (and subsequent fits in the same tab) are successful for both versions of bumps.

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bumps master branch no longer compatible with SasView
1 participant