Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.0.0 notes #2664

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Release 6.0.0 notes #2664

merged 2 commits into from
Oct 24, 2023

Conversation

wpotrzebowski
Copy link
Contributor

Description

This PR addresses two issues related to continuous integration for release_6.0: 1) It uses GH action that allows notarization with notarytool (compare to atool that won't be supported fron Nov 1st). 2) It automatically uploads release notes (so they don't disappear when upload action is pushed). We will need to make a decision whether this right approach for keeping GH release notes in the future. (One can still edit release page on GH and this file won't be aware of it).

How Has This Been Tested?

Installed sasview from installer file and checked if it runs (and if it is signed)

Review Checklist (please remove items if they don't apply):

  • Code has been reviewed
  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)
  • The introduced changes comply with SasView license (BSD 3-Clause)

* @gdrosos made their first contribution in https://github.com/SasView/sasview/pull/2585
* @astellhorn made their first contribution in https://github.com/SasView/sasview/pull/2610

**Full Changelog**: https://github.com/SasView/sasview/compare/nightly-build...v6.0.0-alpha
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this full changelog URL compare 5.0.6 to 6.0.0-alpha? Comparing to the nightly-build tag (which was tagged at some point during codecamp Oct 2022, from what I can see) doesn't seem right.

I suspect there's also a stack of PRs that aren't listed in the What's Changed section, perhaps because they were merged prior to the nightly-build tag but after the branch point for release_5.0.6? (I've not looked in detail, but I think all the stuff I was doing in late 2022 wasn't destined for 5.0.6 but was held over for 6.0.0 and isn't listed there)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the notes themself need to be worked on. This is more of the template. The main point of this is that release notes disappear every time someone pushes to the branch, so this is mostly to prevent empty records on this page: https://github.com/SasView/sasview/releases/tag/v6.0.0-alpha

@butlerpd butlerpd added the Discuss At The Call Issues to be discussed at the fortnightly call label Oct 23, 2023
@butlerpd butlerpd merged commit f07a0c1 into release_6.0.0 Oct 24, 2023
37 checks passed
@butlerpd butlerpd deleted the release_6.0.0_notes branch October 24, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discuss At The Call Issues to be discussed at the fortnightly call
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants