Skip to content

Commit

Permalink
Merge branch 'release_6.0.1' into platfromdirs
Browse files Browse the repository at this point in the history
  • Loading branch information
krzywon authored Jan 15, 2025
2 parents c27c3c7 + 13ba493 commit 45a487f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ jobs:
primary-bundle-id: "org.sasview.SasView6"
appstore-connect-username: ${{ secrets.NOTARIZATION_USERNAME }}
appstore-connect-password: ${{ secrets.NOTARIZATION_PASSWORD }}
appstore-connect-team-id: W2AG9MPZ43
appstore-connect-team-id: 8CX8K63BQM
verbose: True

- name: Staple Release Build (OSX)
Expand Down
2 changes: 1 addition & 1 deletion src/sas/qtgui/MainWindow/DataExplorer.py
Original file line number Diff line number Diff line change
Expand Up @@ -2069,7 +2069,7 @@ def updateTheoryFromPerspective(self, model_item):
self.theory_model.appendRow(model_item)
return model_item

def deleteIntermediateTheoryPlotsByModelID(self, model_id):
def deleteIntermediateTheoryPlotsByTabId(self, tab_id):
"""Given a model's ID, deletes all items in the theory item model which reference the same ID. Useful in the
case of intermediate results disappearing when changing calculations (in which case you don't want them to be
retained in the list)."""
Expand Down
6 changes: 3 additions & 3 deletions src/sas/qtgui/MainWindow/GuiManager.py
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ def addCallbacks(self):
self.communicate.progressBarUpdateSignal.connect(self.updateProgressBar)
self.communicate.perspectiveChangedSignal.connect(self.perspectiveChanged)
self.communicate.updateTheoryFromPerspectiveSignal.connect(self.updateTheoryFromPerspective)
self.communicate.deleteIntermediateTheoryPlotsSignal.connect(self.deleteIntermediateTheoryPlotsByModelID)
self.communicate.deleteIntermediateTheoryPlotsSignal.connect(self.deleteIntermediateTheoryPlotsByTabId)
self.communicate.plotRequestedSignal.connect(self.showPlot)
self.communicate.plotFromNameSignal.connect(self.showPlotFromName)
self.communicate.updateModelFromDataOperationPanelSignal.connect(self.updateModelFromDataOperationPanel)
Expand Down Expand Up @@ -1331,12 +1331,12 @@ def updateTheoryFromPerspective(self, index):
return
per.currentTab.setTheoryItem(item)

def deleteIntermediateTheoryPlotsByModelID(self, model_id):
def deleteIntermediateTheoryPlotsByTabId(self, tab_id):
"""
Catch the signal to delete items in the Theory item model which correspond to a model ID.
Send the request to the DataExplorer for updating the theory model.
"""
self.filesWidget.deleteIntermediateTheoryPlotsByModelID(model_id)
self.filesWidget.deleteIntermediateTheoryPlotsByTabId(tab_id)

def updateModelFromDataOperationPanel(self, new_item, new_datalist_item):
"""
Expand Down
2 changes: 1 addition & 1 deletion src/sas/qtgui/Perspectives/Fitting/FittingWidget.py
Original file line number Diff line number Diff line change
Expand Up @@ -3301,7 +3301,7 @@ def complete1D(self, return_data):
else:
# delete theory items for the model, in order to get rid of any
# redundant items, e.g. beta(Q), S_eff(Q)
self.communicate.deleteIntermediateTheoryPlotsSignal.emit(self.kernel_module.id)
self.communicate.deleteIntermediateTheoryPlotsSignal.emit(str(self.tab_id))

self._appendPlotsPolyDisp(new_plots, return_data, fitted_data)

Expand Down

0 comments on commit 45a487f

Please sign in to comment.