Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for skipped job and step status #113

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

SanjulaGanepola
Copy link
Owner

@SanjulaGanepola SanjulaGanepola commented Dec 10, 2024

Changes

  • Add skipped job and step status

TODO

  • Handle when user selects verbose option in the setting
  • Handle Post Checkout being skipped

@SanjulaGanepola
Copy link
Owner Author

@ChristopherHX The skipped job and step status is showing up properly now in the UI. However, as you can see in the below screen cap, there is a skipped Post Checkout.

  1. Is there a reason act adds this?
  2. Does it make sense to simply filter out all skipped steps for pre and post stage?

image

This uses the following workflow:

name: Sample

on:
  push:
    branches: ["main"]

jobs:
  sample:
    name: SAMPLE

    runs-on: ubuntu-latest

    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: First Echo
        if: ${{ !env.ACT }}
        run: echo 'HI'
      - name: Second Echo
        run: echo 'BYE'

  test:
    name: Test
    if: ${{ !github.event.act }}
    runs-on: ubuntu-latest

    steps:
      - name: Checkout
        uses: actions/checkout@v4

@SanjulaGanepola SanjulaGanepola linked an issue Dec 10, 2024 that may be closed by this pull request
@SanjulaGanepola
Copy link
Owner Author

@ChristopherHX I am also planning to create a new release once this change is merged.

@ChristopherHX
Copy link
Contributor

2. Does it make sense to simply filter out all skipped steps for pre and post stage?

Yes this makes sense.

  1. Is there a reason act adds this?

This is how contributors implemented it, action.yml has also an if condition for them and the verbose mode of act is just verbose.

Not my code.

@ChristopherHX
Copy link
Contributor

I am also planning to create a new release once this change is merged.

ok, do what you think is good.

For my extension on the marketplace I sometimes publish some preview version that can be downloaded optionally, but not every user get's directly installed

There are always bugs, you notice some days after releasing.

@SanjulaGanepola SanjulaGanepola merged commit 0d833e2 into main Dec 11, 2024
2 checks passed
@SanjulaGanepola SanjulaGanepola deleted the feature/skip-status branch December 11, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show skipped steps and jobs
2 participants