Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add unit tests for uncovered function #645

Merged
merged 1 commit into from
Oct 30, 2024
Merged

test: Add unit tests for uncovered function #645

merged 1 commit into from
Oct 30, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Current PR contains small fixes in the source code and adds new unit tests for functions that are not covered by unit tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Local run.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Oct 30, 2024
@o-kopysov o-kopysov added this to the v2.0.2 milestone Oct 30, 2024
@o-kopysov o-kopysov self-assigned this Oct 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (492db95) to head (2184d5c).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #645      +/-   ##
============================================
+ Coverage     93.89%   94.39%   +0.49%     
- Complexity      640      647       +7     
============================================
  Files            52       52              
  Lines          2195     2193       -2     
  Branches        254      253       -1     
============================================
+ Hits           2061     2070       +9     
+ Misses           58       53       -5     
+ Partials         76       70       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Shik-shik Shik-shik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added unit tests. Approved.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 3c26d44 into main Oct 30, 2024
10 checks passed
@o-kopysov o-kopysov deleted the fix-cov branch October 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants