Feature draw #80
Feature draw #80
Conversation
|
Can you submit a screenshot example of eah? |
It would be hard to explain the difference in screenshots... |
| @@ -1,8 +1,8 @@ | |||
| import { ReplayData } from "../../models/ReplayData" | |||
| import { ReplayMetadata } from "../../models/ReplayMetadata" | |||
|
|
|||
| const fetchByURL = (url: string) => | |||
| fetch(url, { | |||
| const fetchByURL = (url: string, local?: boolean) => | |||
There was a problem hiding this comment.
This file changes were just to make fewer network calls while testing.
There was a problem hiding this comment.
Maybe we should make it a prop that is passed in by the host?
That way we can change it as needed in the future?
Especially options as we use it in more and more different places.
There was a problem hiding this comment.
There's an isDevelopment utility here:
https://github.com/SaltieRL/WebReplayViewer/blob/master/src/utils/isDevelopment.ts
There was a problem hiding this comment.
Get's a bit tricky when you are in dev and want to load a different replay, instead of just changing local variable to false or not passing it at all:
- you would need to stop the webpack server
- run webpack-dev-server manually without "--mode development" argument
edit: it turns out that running running without "--mode development" NODE_ENV is still set to development. I needed to specify "--mode production" to get it to be set to production.
Some basic drawing features.
(2D - draw in front of camera, 3D - draw so that objects stick to the field object even when in free cam) - Wasn't sure how to name these modes.
#41