Slim down site and fix many database query issues #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtracers
reviewed
Sep 4, 2020
| @@ -33,13 +34,38 @@ def create_from_id(id_: str, session=None) -> List['PredictedRank']: | |||
| accepted_playlists = [ | |||
| 13, # standard | |||
| 3, # unranked standard | |||
| 6, # custom | |||
| 6, # custom, | |||
There was a problem hiding this comment.
is it required to be in this exact order?
just thinking that putting them in numbered order might be easier to read
dtracers
reviewed
Sep 4, 2020
| ] | ||
| if game.playlist not in accepted_playlists: | ||
| raise UnsupportedPlaylist | ||
|
|
||
| playergames = session.query(PlayerGame).filter(PlayerGame.game == id_).all() | ||
|
|
||
| adjusted_playlist_map = { | ||
| 2: 11, |
dtracers
requested changes
Sep 4, 2020
| @@ -76,12 +74,12 @@ class SideBarComponent extends React.PureComponent<Props> { | |||
| <Divider component="li" /> | |||
|
|
|||
| <ListSubheader>Player</ListSubheader> | |||
| <ListItem button component={this.createLink} to={LEADERBOARDS_LINK}> | |||
| {/* <ListItem button component={this.createLink} to={LEADERBOARDS_LINK}> | |||
There was a problem hiding this comment.
Maybe link a github issue to this so we don't drop it or have no tracking for it long term
There was a problem hiding this comment.
It's not going away. The front page is until I can figure out a better way to get the most recent games
| > | ||
| {playerPlayStyle} | ||
| </PlayerPlayStyleCard> | ||
| {/*<PlayerPlayStyleCard*/} |
There was a problem hiding this comment.
Link this to a github issue to make sure it does not get dropped
| /> | ||
| ) | ||
| // const playerPlayStyle = ( | ||
| // <PlayerPlayStyle |
There was a problem hiding this comment.
Link this to a github issue to make sure it does not get dropped
| @@ -170,26 +167,26 @@ class HomePageComponent extends React.PureComponent<Props, State> { | |||
| {isWidthUp("md", this.props.width) ? ( | |||
| <> | |||
| <Grid item container xs={12} sm={6} lg={4}> | |||
| <Twitch cardStyle={{width: "100%"}} /> | |||
| {/*<Twitch cardStyle={{width: "100%"}} />*/} | |||
There was a problem hiding this comment.
Link these to a github issue to make sure it does not get dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache replay count
Include more ML models