Created app. No styling, does not display statistics. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtracers
reviewed
May 12, 2019
| @@ -1,104 +1 @@ | |||
| # Byte-compiled / optimized / DLL files | |||
| __pycache__/ | |||
There was a problem hiding this comment.
leave this in as you accidentally committed a pyache file
|
@dtracers updated. |
|
@dtracers NOW its good |
dtracers
requested changes
May 12, 2019
| # mypy | ||
| .mypy_cache/ | ||
| node_modules | ||
| __pycache__ |
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. | ||
| Apache License |
There was a problem hiding this comment.
why did you switch out license?
| request("http://127.0.0.1:5000/end") | ||
| win = null; | ||
| }) | ||
| }) |
|
|
||
|
|
||
| @app.route('/upload', methods = ['GET', 'POST']) | ||
| def upload_file(): |
| @app.route('/upload', methods = ['GET', 'POST']) | ||
| def upload_file(): | ||
| if request.method == 'POST': | ||
| template = """ |
There was a problem hiding this comment.
do not put html in a python file
Either use a templeting engine or put the html file client side and have the server just send data.
| body { | ||
| font-family: 'Gugi', cursive; | ||
| } | ||
| #header-img { |
There was a problem hiding this comment.
Styles should be in a separate css file.
| </form> | ||
| </body> | ||
| <script> | ||
| function select(elem) { |
There was a problem hiding this comment.
this much javascript should be in a separate js file if possible
| <script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.14.7/umd/popper.min.js" integrity="sha384-UO2eT0CpHqdSJQ6hJty5KVphtPhzWj9WO1clHTMGa3JDZwrnQq4sF86dIHNDz0W1" crossorigin="anonymous"></script> | ||
| <script src="https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/js/bootstrap.min.js" integrity="sha384-JjSmVgyd0p3pXB1rRibZUAYoIIy6OrQ6VrjIEaFf/nJGzIxFDsf4x0xIM+B07jRM" crossorigin="anonymous"></script> | ||
| </body> | ||
| </html> |
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "replays_path": "\\Documents\\My Games\\Rocket League\\TAGame\\Demos" | |||
| } | |||
| } | ||
| </script> | ||
| </body> | ||
| </html> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the base application that functions. Use launch.bat to open the server and the app; refresh if it does not display the first time.
The app contains no styling as of now, and also does not display stats but has the capability to generate them.