Improve geo_tools.find_closest_model_point() #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update unit tests that weren't adjusted when 'raiseOutOfBounds' parameter was added to find_closest_model_point(). This ensures that a ValueError is raised when raiseOutOfBounds is enabled and latitude and longitude values aren't on the grid.
The unnecessary import statements for netCDF4 and tidetools modules were removed from the unit tests of the geo_tools module in the SalishSeaTools library. This makes the unit tests leaner and reduces dependencies for running the tests.
Add tolerance values for HRDPS continental 2.5 km resolution rotated lat/lon grid that became forcing for SalishSeaCast in Feb-2023.
douglatornell
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tolerance values for HRDPS continental 2.5 km resolution rotated lat/lon grid that became forcing for SalishSeaCast in Feb-2023.
Also clean up code and fix failing unit tests.