Fix failing tidetools test
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced mocked file handling with temporary file creation using `tmp_path`. This ensures better test reliability and readability by using actual file I/O for the namelist input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request includes changes focused on enhancing the failing test for the
tidetools.get_run_lengthfunction, within the Salish Sea tools project. Specifically, this refines the structure of the unit test and solves reliability issues.test_get_run_lengthfunction by using thetmp_pathstrategy to dynamically create a temporary directory and namelist file.textwrap.dedentmodule for better formatting of test data in the test.mock_open,patch) and replaced them with atmp_path-based approach to improve test reliability during filesystem interactions.Refactor and enhanceget_run_lengthtest logic