Update httpx and fix caplog assertions in tests #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded `httpx`, and `pytest-httpx` in `requirements.txt` to newer versions. Adjusted caplog index assertions in test cases to align with the updated logging behavior of `httpx`. This ensures compatibility and correct verification of log records across all affected tests. This issue arose due to a change in the log output of `httpx=0.28.0`. It was found by the GitHub Actions pytest-with-coverage workflows when the tests were run with the updated version of `httpx` in response to an unrelated dependabot PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 77.72% 77.72%
=======================================
Files 133 133
Lines 18778 18778
Branches 762 762
=======================================
Hits 14595 14595
Misses 4117 4117
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded
httpx, andpytest-httpxinrequirements.txtto newer versions. Adjusted caplog index assertions in test cases to align with the updated logging behavior ofhttpx. This ensures compatibility and correct verification of log records across all affected tests.This issue arose due to a change in the log output of
httpx=0.28.0. It was found by the GitHub Actions pytest-with-coverage workflows when the tests were run with the updated version ofhttpxin response to an unrelated dependabot PR.