Add month-averaging of grazing/mortality & biology growth rate variable groups to make_averaged_dataset
#297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These YAML configuration files resample daily biological growth rate and grazing/mortality fields to monthly averages for the SalishSeaCast v202111 model. They specify the variables to extract, the resampling method, and the destination for the output files.
Extended the make_averaged_dataset worker and related test cases to include grazing and growth dataset variable groups. Updated configuration files and added parameter-specific validations for these new variable groups.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
+ Coverage 77.68% 77.69% +0.01%
==========================================
Files 133 133
Lines 18745 18757 +12
Branches 1912 1915 +3
==========================================
+ Hits 14562 14574 +12
Misses 4117 4117
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Updated the nowcast.yaml configuration file to include failure messages for grazing and growth dataset day-averaging. Corresponding test cases were also added to ensure proper error handling for these new scenarios. Missed in ce694e2. Necessary because grazing and growth dataset day-averaging operation requests are rejected to avoid redundant work; those datasets are calculated and output by out NEMO configuration.
Expanded the next_workers module to calculate month-average grazing and growth datasets at month-end. Added corresponding test functions to ensure the new make_averaged_dataset worker instances are launched correctly.
|
Tested successfully in automation on 30-Sep-2024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grazingandgrowthoptions forreshapr_var_groupcommand-line argumentgrazingandgrowthgrazingandgrowthmonth-average datasets at the end of each month