Update dataset variable dropping method in make_CHS_currents_file worker
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test suite maintenance. re: issue #81
Updated the run_type conditionals from if-elif to a match case statement for better clarity and future extensibility. Added error handling to raise a WorkerError if the run_type is unexpected. Although the CLI parser handles that error, adding default case handling prevents static analysis warnings about possible variables references before assignment.
Corrected the format of parameter type definitions in the docstrings for consistency and clarity. This change ensures better readability and proper documentation standards.
Replace unittest.mock.patch decorator with pytest caplog fixture for tests of logging. Test suite maintenance re: issue #82.
Replaced direct patching of fix_perms with a pytest fixture for better test structure and readability. This ensures the mock is applied more cleanly and isolated within the test context.
Replaced direct patching with a pytest fixture to mock the `_write_netcdf` function in unit tests for `make_CHS_currents_file`. This improves test maintainability and readability. Reorganized parameterized tests to adapt to the new mocking approach.
Replaced the deprecated 'drop' method with 'drop_vars' for removing the 'time_centered' variable. This ensures compatibility with newer versions of the xarray library.
Correct the unlimited dimension from "time" to "time_counter" when exporting to netCDF in make_CHS_currents_file.py.
PyCharm generated an import from a build/ directory that was just plain wrong!
Corrected grammatical error and improved the wording of module docstring in `make_CHS_currents_file.py` and its associated tests. Ensured consistent use of terminology by changing "average" to "averages" and specifying "netCDF" instead of "nc file".
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 77.68% 77.68%
=======================================
Files 133 133
Lines 18733 18745 +12
Branches 1909 1912 +3
=======================================
+ Hits 14552 14562 +10
- Misses 4115 4117 +2
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: xarray DeprecationWarning (see issue #291).
Also: