Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update surface_current_tiles figure module re: matplotlib & numpy API changes #292

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

douglatornell
Copy link
Member

re: issue #253

Replace discouraged Axes.set_xticklabels() with Axes.set_xticks() call that
includes both tick locations and labels.

This change silences one of the UserWarnings flagged in issue #253.
Change the latitude parameter in set_aspect() from a masked array to a filled
array to silence one of the UserWarnings flagged in issue #253.
* Drop unused import
* Change to use 202111 model results
* Change to use 201802 bathymetry and mesh mask
* Change to generate plot for 2024-08-30
* Change from arrow.replace() to arrow.shift() re: change in arrow API
@douglatornell douglatornell added maintenance Codebase maintenance Figures Website figure module code labels Aug 30, 2024
@douglatornell douglatornell added this to the v24.2 milestone Aug 30, 2024
@douglatornell douglatornell linked an issue Aug 30, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@531e3d3). Learn more about missing BASE report.
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
nowcast/figures/publish/surface_current_tiles.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage        ?   77.67%           
=======================================
  Files           ?      133           
  Lines           ?    18733           
  Branches        ?     1910           
=======================================
  Hits            ?    14551           
  Misses          ?     4115           
  Partials        ?       67           
Flag Coverage Δ
unittests 77.67% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglatornell douglatornell merged commit 0810d54 into main Aug 30, 2024
8 checks passed
@douglatornell douglatornell deleted the issue253-surface_current_tiles branch August 30, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Figures Website figure module code maintenance Codebase maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarnings in surface_current_tiles figure module
1 participant