Extend worker logging ports list #289
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new worker logging ports (5595 to 5599) to both `tests/test_config.py` and `config/nowcast.yaml`. This is to prevent intermittent worker failures due to all logging ports in use during collecting of obs in the early morning. Additionally, fixed a comment in `nowcast.yaml` to include double quotes around a colon character in the zmq section.
douglatornell
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 77.67% 77.67%
=======================================
Files 133 133
Lines 18733 18733
Branches 1910 1910
=======================================
Hits 14551 14551
Misses 4115 4115
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new worker logging ports (5595 to 5599) to both
tests/test_config.pyandconfig/nowcast.yaml. This is to prevent intermittent worker failures due to all logging ports in use during collecting of obs in the early morning.Additionally, fixed a comment in
nowcast.yamlto include double quotes around a colon character in the zmq section.