Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize test_make_live_ocean_files #288

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

douglatornell
Copy link
Member

No description provided.

Test suite maintenance.

re: issue #81
Replaced `patch` decorators with a pytest fixture to mock
`create_LiveOcean_TS_BCs`. This improves test clarity and ensures the mock is
applied only where necessary. Also adjusted test assertions to use the correct
filepath.
@douglatornell douglatornell added Workers maintenance Codebase maintenance labels Jul 26, 2024
@douglatornell douglatornell added this to the v24.2 milestone Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.67%. Comparing base (f0cf475) to head (e31ba3b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   77.67%   77.67%   -0.01%     
==========================================
  Files         133      133              
  Lines       18735    18733       -2     
  Branches     1909     1910       +1     
==========================================
- Hits        14553    14551       -2     
  Misses       4115     4115              
  Partials       67       67              
Flag Coverage Δ
unittests 77.67% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglatornell douglatornell merged commit 189a9e3 into main Jul 26, 2024
6 of 8 checks passed
@douglatornell douglatornell deleted the modernize-test_make_live_ocean_files branch July 26, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Codebase maintenance Workers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant