Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datetime format in VFPA HADCP observation handling #282

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

douglatornell
Copy link
Member

The datetime parsing format was adjusted in the VFPA HADCP sensor observation handling module. This change will ensure the timestamp is correctly interpreted as YYYY-MM-DD HH:MM as opposed to the previous format DD/MM/YYYY HH:MM. This change was necessitated by a change in the datetime format in the observation .csv files that was made between 17:00 and 18:00 UTC on 2023-07-02.

The datetime parsing format was adjusted in the VFPA HADCP data handling module.
This change will ensure the timestamp is correctly interpreted as
YYYY-MM-DD HH:MM as opposed to the previous format DD/MM/YYYY HH:MM. This change
was necessitated by a change in the datetime format in the observation .csv
files that was made between 17:00 and 18:00 UTC on 2023-07-02.
@douglatornell douglatornell added bug Something isn't working Workers labels Jul 12, 2024
@douglatornell douglatornell added this to the v24.2 milestone Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (66db22d) to head (2d149fd).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
nowcast/workers/get_vfpa_hadcp.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   77.65%   77.65%           
=======================================
  Files         133      133           
  Lines       18695    18695           
  Branches     1910     1910           
=======================================
  Hits        14517    14517           
  Misses       4111     4111           
  Partials       67       67           
Flag Coverage Δ
unittests 77.65% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglatornell
Copy link
Member Author

Successfully used in bash loops in production environment to backfill 3-Jul-2023 to 12-Jul-2024 obs csv files into netCDF dataset.

@douglatornell douglatornell merged commit 95a9863 into main Jul 13, 2024
6 of 8 checks passed
@douglatornell douglatornell deleted the chg-get_vfpa_hadcp-csv-time-format branch July 13, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Workers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant