Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve crop_gribs --backfill completion log message #279

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

douglatornell
Copy link
Member

The log messages at the completion of the crop_gribs worker with the --backfill option has been improved from referring to a specific file to referring to the directory tree containing all the cropped files.

The log messages at the completion of the crop_gribs worker with the
`--backfill` option has been improved from referring to a specific file to
referring to the directory tree containing all the cropped files.
@douglatornell douglatornell added bug Something isn't working Workers labels Jun 26, 2024
@douglatornell douglatornell added this to the v24.2 milestone Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.65%. Comparing base (d9f5fbf) to head (a4a827c).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   77.65%   77.65%           
=======================================
  Files         133      133           
  Lines       18695    18695           
  Branches     1910     1910           
=======================================
  Hits        14517    14517           
  Misses       4111     4111           
  Partials       67       67           
Flag Coverage Δ
unittests 77.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglatornell douglatornell merged commit ffed73d into main Jun 26, 2024
7 of 8 checks passed
@douglatornell douglatornell deleted the improve-crop_gribs-backfill-log-msg branch June 26, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Workers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant