Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'np.NaN' to 'np.nan' re: Numpy 2.0 #272

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Change 'np.NaN' to 'np.nan' re: Numpy 2.0 #272

merged 1 commit into from
Jun 13, 2024

Conversation

douglatornell
Copy link
Member

'numpy.nan' is the correct spelling in Numpy 2.0. All others are deprecated.

 'numpy.nan' is the correct spelling in Numpy 2.0. All others are deprecated.
@douglatornell douglatornell added the maintenance Codebase maintenance label Jun 13, 2024
@douglatornell douglatornell added this to the v24.1 milestone Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.64%. Comparing base (4d01c91) to head (6296683).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
nowcast/figures/research_ferries.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   77.64%   77.64%           
=======================================
  Files         133      133           
  Lines       18695    18695           
  Branches     1910     1910           
=======================================
  Hits        14515    14515           
  Misses       4113     4113           
  Partials       67       67           
Flag Coverage Δ
unittests 77.64% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglatornell douglatornell merged commit 47e03bc into main Jun 13, 2024
7 of 8 checks passed
@douglatornell douglatornell deleted the numpy-nan branch June 13, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Codebase maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant