Update ONC VENUS nodes model/obs comparison figure module #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds the Jupyter 'notebook' package to the environment for figures development in environment-fig-dev.yaml. It used to be installed as a dependency of the 'jupyterlab' package, but now must be installed separately.
A docstring was added to compare_venus_ctd.py. It includes an explanation of the figure that the module created and the link to its testing notebook.
The code in compare_venus_ctd.py has been updated to gracefully handle cases when the development run fields dataset (dev_grid_T_hr) is missing or not provided. Previously, missing development grid data would have caused an exception. Now, the code tests for this condition and sets other corresponding variables to None as necessary, preventing the figure generation from crashing. This elimination of unwanted exceptions makes the application more robust and easier to maintain.
The data_tools.get_onc_data() call in the compare_venus_ctd figure module was updated to use the ONC API v3. Parameters "getByStation", "station", "deviceCategory", and "sensors" have been replaced with "getByLocation", "locationCode", "deviceCategoryCode", and "sensorCategoryCodes", respectively.
douglatornell
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 77.79% 77.77% -0.03%
==========================================
Files 133 133
Lines 18817 18822 +5
Branches 1910 1914 +4
==========================================
Hits 14639 14639
- Misses 4111 4116 +5
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This commit adjusts the handling of 'nowcast-dev' configuration entry in 'nowcast.yaml' and 'make_plots.py'. If 'nowcast-dev' results archive path is set to 'None', the code no longer tries to work with non-existent directories. This change is reflected in update of related tests as well.
The "Compare_VENUS_Delta_DDL" figure calculation has been removed from the make_plots worker. The ONC DDL node deployment ended in Mar-2024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nowcast-devwith the release of v202111