Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation maintenance #248

Merged
merged 12 commits into from
Mar 27, 2024
Merged

Documentation maintenance #248

merged 12 commits into from
Mar 27, 2024

Conversation

douglatornell
Copy link
Member

No description provided.

@douglatornell douglatornell added documentation Improvements or additions to documentation maintenance Codebase maintenance labels Mar 21, 2024
@douglatornell douglatornell added this to the v24.1 milestone Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.73%. Comparing base (a9196e7) to head (5d80da1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   77.73%   77.73%   -0.01%     
==========================================
  Files         133      133              
  Lines       18771    18769       -2     
  Branches     1906     1906              
==========================================
- Hits        14592    14590       -2     
  Misses       4112     4112              
  Partials       67       67              
Flag Coverage Δ
unittests 77.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dask.distributed 2022.10.0 deprecated the `dask-scheduler` and `dask-worker` CLI
commands in favour of `dask scheduler` and `dask worker`.
This commit modifies the instructions in the deployment docs for the persistent
dask cluster on `salish` that the `make_averaged_dataset` worker uses. It
changes the number of threads for each worker from 4 to 1, the memory limit from
automatic to 64G, and worker files will now be stored on the /tmp/ file system
instead of /dev/shm shared memory file system.

The change to 1 thread per worker is a consequence of reading
xCDAT/xcdat#561 (comment). Changing the
memory limit and worker file storage are a result of research and testing on
1mar24 (see worklog for details).
The NEMO_Nowcast package is now installed in the readthedocs build environment.
So, autodoc mocks for its imports are no longer required. Removing those mocks
silences warnings about mocked objects and missing attributes for the
`clear_checklist` and `rotate_logs` worker docs.
This resolves an import error that prevents generation of docs for the
`make_averaged_dataset` worker on readthedocs.
Changed all the kbd directives in the skookum deployment documentation into
inline code. This helps to ensure the correct semantic representation of
technical terms and commands.

re: issue #126
@douglatornell douglatornell linked an issue Mar 26, 2024 that may be closed by this pull request
Changed all the kbd directives in the documentation into inline code. This helps
to ensure the correct semantic representation of technical terms and commands.

re: issue #126
Two unused Python library imports, pathlib and requests, were removed from
wave_height_period.py. This cleanup improves the code readability and efficiency.
The documentation has been updated to reflect the change in the automatic code
formatting tool used by the `salishsea_site` and `SalishSeaNowcast` packages.
Previously, we were using `yapf`, but switched to `black`.
The documentation now contains a guide for generating passphrase-less RSA and
ED25519 key pairs for the remote hosts that SalishSeaCast uses. It includes
commands to install the public keys and to edit the ssh configuration file on
'skookum'.
@douglatornell douglatornell linked an issue Mar 27, 2024 that may be closed by this pull request
@douglatornell douglatornell merged commit 2bdd7ca into main Mar 27, 2024
7 checks passed
@douglatornell douglatornell deleted the docs-maint branch March 27, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Codebase maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ssh config & keys sections to deployment docs Review use of :kbd: role in docs
1 participant