Update to Python 3.12 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us use the workflow to test whether all the packages NEMO-Cmd depends on have been updated to support Python 3.12.
Enables workflow to be triggered from GitHub CLI, browser, or via API.
This is primarily to allow the workflow to be run via
gh workflow run pytest-with-coverage --ref py312
during the conda-forge Python 3.12 migration to test if the environment is
solvable yet.
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.6 to 2.0.7. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.0.6...2.0.7) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 77.73% 77.73%
=======================================
Files 133 133
Lines 18723 18724 +1
Branches 1976 1910 -66
=======================================
+ Hits 14554 14555 +1
Misses 4110 4110
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Bad assertion was present for some time allowing test to always pass. Upgrading to Python 3.12 revealed it with a test failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow_dispatchtrigger to GHA pytest-with-coverage workflow to enable workflow to be triggered fromGitHub CLI, browser or via API
pyproject.toml project.requires-pythonto >=3.12environment-dev.yamlenvironment-fig-dev.yamlenvironment-prod.yamlenvironment-rtd.yaml