Remove 'make_runoff_file' from automation workflow

The 'make_runoff_file' worker has been removed from the 'next_workers' module
because it is replaced by 'make_20211_runoff_file' for v202111. The associated
tests have been updated or removed.

nowcast/next_workers.py

@@ -84,7 +84,6 @@ def after_download_weather(msg, config, checklist):
                 )
                 race_condition_workers = {
                     "grib_to_netcdf",
-                    "make_runoff_file",
                     "make_v202111_runoff_file",
                 }
                 return next_workers[msg.type], race_condition_workers
@@ -106,7 +105,6 @@ def after_download_weather(msg, config, checklist):
             race_condition_workers = {
                 "grib_to_netcdf",
                 "make_live_ocean_files",
-                "make_runoff_file",
                 "make_v202111_runoff_file",
             }
             return next_workers[msg.type], race_condition_workers
@@ -391,7 +389,6 @@ def after_make_ssh_files(msg, config, checklist):
         next_workers[msg.type].append(
             NextWorker("nowcast.workers.make_v202111_runoff_file")
         )
-        next_workers[msg.type].append(NextWorker("nowcast.workers.make_runoff_file"))
     return next_workers[msg.type]
 
 

tests/test_next_workers.py

@@ -213,7 +213,6 @@ def mock_now():
         assert workers == expected
         assert race_condition_workers == {
             "grib_to_netcdf",
-            "make_runoff_file",
             "make_v202111_runoff_file",
         }
 
@@ -240,7 +239,6 @@ def mock_now():
         assert race_condition_workers == {
             "grib_to_netcdf",
             "make_live_ocean_files",
-            "make_runoff_file",
             "make_v202111_runoff_file",
         }
 
@@ -336,7 +334,6 @@ def mock_now():
         assert workers == expected
         assert race_condition_workers == {
             "grib_to_netcdf",
-            "make_runoff_file",
             "make_v202111_runoff_file",
         }
 
@@ -367,7 +364,6 @@ def mock_now():
         assert race_condition_workers == {
             "grib_to_netcdf",
             "make_live_ocean_files",
-            "make_runoff_file",
             "make_v202111_runoff_file",
         }
 
@@ -557,13 +553,6 @@ def test_success_launch_make_v202111_runoff_file(self, msg_type, config, checkli
         )
         assert workers[0] == NextWorker("nowcast.workers.make_v202111_runoff_file")
 
-    @pytest.mark.parametrize("msg_type", ["success nowcast", "success forecast2"])
-    def test_success_launch_make_runoff_file(self, msg_type, config, checklist):
-        workers = next_workers.after_make_ssh_files(
-            Message("make_ssh_files", msg_type), config, checklist
-        )
-        assert workers[1] == NextWorker("nowcast.workers.make_runoff_file")
-
 
 class TestAfterGribToNetcdf:
     """Unit tests for the after_grib_to_netcdf function."""