Prevent duplicate effort on vcs revision recording of NEMO and XIOS-2 code repository clones #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A check was added to 'salishsea_cmd/prepare.py' to prevent vcs revision recording of the NEMO and XIOS-2 code repositories. That duplication could happen because the code always records the vcs revision of the NEMO and XIOS-2 code repositories, but the user could cause duplicated effort by including those repositories in their YAML file list of other repos to record. Corresponding tests were updated to reflect these changes. re: issue #11
douglatornell
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 95.21% 95.36% +0.14%
==========================================
Files 10 10
Lines 1296 1316 +20
Branches 237 241 +4
==========================================
+ Hits 1234 1255 +21
+ Misses 58 57 -1
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This commit replaces instances of `tmpdir` with `tmp_path` from pytest and uses `pathlib` to handle file paths. Additionally, all path conversions now use `os.fspath()` for consistent, cross-platform compatibility. These changes improve code readability and ensure the test suite is using more modern file handling practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A check was added to 'salishsea_cmd/prepare.py' to prevent vcs revision recording of the NEMO and XIOS-2 code repositories. That duplication could happen because the code always records the vcs revision of the NEMO and XIOS-2 code repositories, but the user could cause duplicated effort by including those repositories in their YAML file list of other repos to record. Corresponding tests were updated to reflect these changes.
re: issue #11