Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do VCS recording of NEMO and XIOS-2 clone only once #11

Open
douglatornell opened this issue Oct 25, 2021 · 1 comment · Fixed by #69
Open

Do VCS recording of NEMO and XIOS-2 clone only once #11

douglatornell opened this issue Oct 25, 2021 · 1 comment · Fixed by #69
Assignees
@douglatornell
Labels
enhancement New feature or request minor prepare plug-in
Milestone
v24.1

Comments

@douglatornell
Copy link
Member

If a user includes the NEMO and/or XIOS-2 code repo clone paths in the vcs revisions section of the YAML run description, the VCS recording code is run twice for those repos because they are also implicitly added to the list of repos to process.

Need to add code to ensure that those repos appear only once in the list.
@douglatornell douglatornell added this to the Future milestone Oct 25, 2021
@douglatornell douglatornell self-assigned this Oct 25, 2021
@douglatornell douglatornell modified the milestones: Future, v23.1 Dec 22, 2022
@douglatornell douglatornell modified the milestones: v23.1, v23.2 Nov 29, 2023
douglatornell added a commit that referenced this issue Jul 5, 2024
@douglatornell
Prevent vcs revision recording of duplicate repos
9fde4e2 
A check was added to 'salishsea_cmd/prepare.py' to prevent vcs revision
recording of the NEMO and XIOS-2 code repositories. That duplication could
happen because the code always records the vcs revision of the NEMO and XIOS-2
code repositories, but the user could cause duplicated effort by including those
repositories in their YAML file list of other repos to record. Corresponding
tests were updated to reflect these changes.

re: issue #11
@douglatornell douglatornell mentioned this issue Jul 5, 2024
Merged
@douglatornell douglatornell linked a pull request Jul 5, 2024 that will close this issue
Prevent duplicate effort on vcs revision recording of NEMO and XIOS-2 code repository clones #69
Merged
douglatornell added a commit that referenced this issue Jul 5, 2024
@douglatornell
Prevent duplicate effort on vcs revision recording of NEMO and XIOS-2…
44bbbf4 
… code repository clones (#69)

* Prevent vcs revision recording of duplicate repos

A check was added to 'salishsea_cmd/prepare.py' to prevent vcs revision
recording of the NEMO and XIOS-2 code repositories. That duplication could
happen because the code always records the vcs revision of the NEMO and XIOS-2
code repositories, but the user could cause duplicated effort by including those
repositories in their YAML file list of other repos to record. Corresponding
tests were updated to reflect these changes.

re: issue #11

* Update test_prepare.py to use tmp_path & os.fspath

This commit replaces instances of `tmpdir` with `tmp_path` from pytest and uses
`pathlib` to handle file paths. Additionally, all path conversions now use
`os.fspath()` for consistent, cross-platform compatibility. These changes
improve code readability and ensure the test suite is using more modern file
handling practices.
@douglatornell
Copy link
Member Author

Duplicate vcs revision recording of NEMO-3.6-code repository is still being observed on graham and salish :-(

@douglatornell douglatornell reopened this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@douglatornell douglatornell

Labels
enhancement New feature or request minor prepare plug-in
Projects
None yet
Milestone
v24.1
1 participant
@douglatornell