Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop importlib_metadata dependency #281

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

lochhh
Copy link
Contributor

@lochhh lochhh commented Nov 10, 2023

Since aeon_mecha supports only Python >=3.11, it makes sense to drop the importlib_metadata dependency and use the Python built-in importlib.metadata module

This PR resolves #280.

Summary by CodeRabbit

  • Refactor: Replaced the importlib_metadata dependency with the built-in Python importlib.metadata module in aeon/__init__.py. This change enhances the maintainability of the code by reducing external dependencies. The update does not affect any existing functionalities or interfaces, ensuring a seamless experience for end-users.

Copy link

github-actions bot commented Nov 10, 2023

Image description CodeRabbit

Walkthrough

The overall change in the code is a replacement of the importlib_metadata dependency with Python's built-in importlib.metadata module. This change does not affect the external interface or behavior of the code, as there are no alterations to the signatures of exported functions, global data structures, or variables.

Changes

File Summary
aeon/init.py The importlib_metadata dependency has been replaced with the Python built-in importlib.metadata module. No changes have been made to the signatures of exported functions, global data structures, or variables. The external interface and behavior of the code remain unchanged.

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 34d16fa and 57b4b9e commits.
Files selected (1)
  • aeon/init.py (2)
Files ignored due to filter (1)
  • pyproject.toml
Files skipped from review due to trivial changes (1)
  • aeon/init.py
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@jkbhagatio jkbhagatio merged commit d3588d3 into main Nov 15, 2023
5 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
@lochhh lochhh deleted the drop-importlib-dependency branch January 24, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace importlib_metadata with importlib.metadata
3 participants