Skip to content

Commit

Permalink
try to isolate aws configure credentials outside of docker build
Browse files Browse the repository at this point in the history
  • Loading branch information
rxu17 committed Jul 7, 2024
1 parent e0f8f4d commit 2f491d6
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/upload-and-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ env:
PROD_INPUT_BUCKET: recover-input-data
PROD_INTERMEDIATE_BUCKET: recover-intermediate-data
INTEGRATION_TEST_NUM_EXPORTS: 28
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
#ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

jobs:

Expand Down Expand Up @@ -118,6 +118,12 @@ jobs:
dockerfile: tests/Dockerfile.aws_glue_4
environment: develop
steps:
- name: Checkout repository
uses: actions/checkout@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Assume AWS role
uses: aws-actions/configure-aws-credentials@v2
with:
Expand All @@ -137,10 +143,6 @@ jobs:
echo "username-key=$usernameKey" >> $GITHUB_OUTPUT
passwordKey=docker_password_$(echo ${{ steps.login-ecr.outputs.registry }} | tr '.-' _)
echo "password-key=$passwordKey" >> $GITHUB_OUTPUT
- uses: actions/checkout@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
- name: Build and push to ECR
id: docker-build-push
Expand Down

0 comments on commit 2f491d6

Please sign in to comment.