SEBSERV-456 and FeatureService deprecation

SafeExamBrowser · Jan 18, 2024 · aec6bd6 · aec6bd6
1 parent 52e2a83
commit aec6bd6
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/src/main/java/ch/ethz/seb/sebserver/gbl/FeatureService.java b/src/main/java/ch/ethz/seb/sebserver/gbl/FeatureService.java
@@ -12,6 +12,8 @@
 import ch.ethz.seb.sebserver.gbl.model.exam.ProctoringServiceSettings.ProctoringServerType;
 import ch.ethz.seb.sebserver.gbl.model.institution.LmsSetup.LmsType;
 
+@Deprecated // we need another more flexible feature service that also take new User Role and Privileges into account
+            // SEBSERV-497
 public interface FeatureService {
 
     String FEATURE_SETTINGS_PREFIX = "sebserver.feature.";

diff --git a/src/main/java/ch/ethz/seb/sebserver/gbl/FeatureServiceImpl.java b/src/main/java/ch/ethz/seb/sebserver/gbl/FeatureServiceImpl.java
@@ -20,6 +20,8 @@
 @Lazy
 @Service
 @WebServiceProfile
+@Deprecated // we need another more flexible feature service that also take new User Role and Privileges into account
+// SEBSERV-497
 public class FeatureServiceImpl implements FeatureService {
 
     private final Environment environment;

diff --git a/src/main/java/ch/ethz/seb/sebserver/gbl/model/sebconfig/SEBClientConfig.java b/src/main/java/ch/ethz/seb/sebserver/gbl/model/sebconfig/SEBClientConfig.java
@@ -511,7 +511,7 @@ public static SEBClientConfig createNew(final Long institutionId, final long pin
                 null,
                 institutionId,
                 null,
-                ConfigPurpose.CONFIGURE_CLIENT,
+                ConfigPurpose.START_EXAM,
                 pingIterval,
                 VDIType.NO,
                 null,

diff --git a/...n/java/ch/ethz/seb/sebserver/webservice/servicelayer/dao/impl/SEBClientConfigDAOImpl.java b/...n/java/ch/ethz/seb/sebserver/webservice/servicelayer/dao/impl/SEBClientConfigDAOImpl.java
@@ -532,7 +532,7 @@ private void saveAdditionalAttributes(final SEBClientConfig sebClientConfig, fin
                 SEBClientConfig.ATTR_CONFIG_PURPOSE,
                 (sebClientConfig.configPurpose != null)
                         ? sebClientConfig.configPurpose.name()
-                        : ConfigPurpose.CONFIGURE_CLIENT.name());
+                        : ConfigPurpose.START_EXAM.name());
 
         this.additionalAttributesDAO.saveAdditionalAttribute(
                 EntityType.SEB_CLIENT_CONFIGURATION,