Optimise the support for <script>, <style> and other similar non-html elements #3

SYM01 · 2023-12-13T14:02:46Z

Thinking about the following HTML

<body>
	<div>
	<h1>Example Domain</h1>
	<p><a href="https://www.iana.org/domains/example">More information...</a></p>
	</div>
	<script>alert(1)</script>
</body>

The expected output should be

	<div>
	<h1>Example Domain</h1>
	<p><a href="https://www.iana.org/domains/example">More information...</a></p>
	</div>

However, in the previous version, the output looks like

	<div>
	<h1>Example Domain</h1>
	<p><a href="https://www.iana.org/domains/example">More information...</a></p>
	</div>
	alert(1)

The output is unexpected. So we need to optimise the support for <script>, <style>.

codecov · 2023-12-13T14:04:03Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1c78ca2) 95.16% compared to head (a2afdf9) 95.27%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
dfa.go	96.34%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   95.16%   95.27%   +0.10%     
==========================================
  Files           3        3              
  Lines         538      614      +76     
==========================================
+ Hits          512      585      +73     
- Misses         18       20       +2     
- Partials        8        9       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SYM01 added 6 commits December 12, 2023 20:13

minor optimize

4211831

[WIP] support script/style/object tags

a5da2ca

[WIP] improve test coverage

94bb9ea

optimized README.md

38e3bd6

expose a cmd for quick use / test

0e6cfd9

optimize non-html element filter and add fuzz test case

bb40556

minor improve

a2afdf9

SYM01 merged commit 87a0f56 into master Dec 13, 2023
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimise the support for <script>, <style> and other similar non-html elements #3

Optimise the support for <script>, <style> and other similar non-html elements #3

SYM01 commented Dec 13, 2023

codecov bot commented Dec 13, 2023 •

edited

Loading

Optimise the support for <script>, <style> and other similar non-html elements #3

Optimise the support for <script>, <style> and other similar non-html elements #3

Conversation

SYM01 commented Dec 13, 2023

codecov bot commented Dec 13, 2023 • edited Loading

Codecov Report

codecov bot commented Dec 13, 2023 •

edited

Loading