What if some recipients decline / revoke the share?

[michielbdejong]

No description provided.

[michielbdejong]

Local users cannot refuse a share, but foreign recipients can.
It gets particularly tricky when some recipients decline / revoke the share, and others don't.
How should we deal with that?

[michielbdejong]

What if we create a full two-sided federated share for each foreign group member?
That would have the effect that the remote user can interact with the share without having to even know whether it was shared just with them or also with other people.
Would have to try out what this looks like in the GUI.

[michielbdejong]

Local groups actually also have individual declines

[michielbdejong]

Suppose there are 3 servers (A,B,C) and on each server there are 3 group members (A1,A2,A3,B1,B2,B3,C1,C2,C3).
User A1 shares a folder with the group.

• On server A, one entry in the oc_share is created.
• On server B, 3 entries in oc_share_external are created.
• On server C, 3 entries in oc_share_external are created.

I think that is the setup I should try to build first, and then see how that works in practice.

[michielbdejong]

Rule of thumb is that it should work the same when you receive a share through a federated (custom or regular) group as when you receive a share through a local (custom or regular) group.

[shokri-navid]

the share entry status in oc_share_external will be changed to 2

[michielbdejong]

Hm, but when you receive a share through a local (custom or regular) group then there is no entry in oc_share_external, right? So that can't be the answer?
As you remarked in #28 (comment) points 2 and 3 the behaviour is different depending on whether all group members have set the checkbox to automatically accept group shares or not. Can you describe exactly what happens in both cases when:

• a share is created
• a group member accepts the share (if applicable)
• a group member rejects the share (if applicable)
• the owner deletes the file that was shared
• another group member deletes the file that was shared
• the owner revokes the share
• another group member revokes the share

[michielbdejong]

For local sharing to a regular group:

• a type 1 share is created to the group (accepted 0)
• for each user that doesn't have automatic accepting an additional type 2 share is created (accepted 1, "pending")

When John declines, accepted for his line changes to 2 (denied).
When he accepts, accepted changes to 0 (accepted)

[michielbdejong]

For custom group, it's the same except that the value of share_with is customgroup_custom (for custom group name 'custom').

[michielbdejong]

When the sharer deletes the item that was shared, the share silently disappears from everybody else's account.

[michielbdejong]

If you decline a share after it was automatically accepted, then it also adds a row for you with share_type 2 and accepted 2.

[michielbdejong]

The type-2 shares have the id of the type-1 shares in a parent column.

[michielbdejong]

Nextcloud has IShare::TYPE_REMOTE_GROUP