Reduce code surface

[michielbdejong]

The app code comes together, mainly through copy-paste from two sources:

• ShareProviderFactory comes from https://github.com/owncloud/core/blob/master/lib/private/Share20/ProviderFactory.php
• ShareProvider comes partially from https://github.com/owncloud/core/blob/master/lib/private/Share20/DefaultShareProvider.php
• and partially from https://github.com/owncloud/core/blob/master/apps/federatedfilesharing/lib/FederatedShareProvider.php#L220

One way to reduce this surface is to extend from FederatedShareProvider and overwrite the addShareToDb method, and same for the other two classes?

[michielbdejong]

OCA\FederatedGroups\LocalShareProvider
OCA\FederatedGroups\RemoteShareProvider

[michielbdejong]

If we create a full two-sided federated share for each group member as per #18 (comment) then we don't even need the RemoteShareProvider class that skips the add-to-local-db step. We would just create 1 local group share and n federated shares.

[michielbdejong]

Code surface reduced to 300 lines :)

   6 appinfo/app.php
  28 appinfo/info.xml
   9 appinfo/routes.php
  14 lib/Application.php
 154 lib/GroupShareProvider.php
  97 lib/ShareProviderFactory.php
 308 total