Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Point cloud loaders (LAS and TXT) #978
base: release-candidate
Are you sure you want to change the base?
Add Point cloud loaders (LAS and TXT) #978
Changes from 5 commits
df9d559
9eccdfb
afaa7d9
5e396dd
faa0394
b478589
9e979c3
d171d97
3573b19
814211f
bbf1404
1e49cd1
2c53183
211b6f6
c16169b
85c7236
5b6f991
6f9e1fa
c21c520
c06f7a0
c974425
769a183
2a258b8
4b470bd
2f6cfde
1ded72e
b361d35
d830798
484848f
c30f473
4fc2c2b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid code duplication.
One option could be to test all positions at once, and throw a generic error message, e.g.,
ile does not contain mandatory properties (X, Y, Z, time). aborting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this implementation, your loader can only load the x,y,z and time fields.
I would be better to load all the fields, then aggregate x,y,z, and add the position, and custom fields in the Radium datastructure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated implementation to load all attributes as custom and aggregate x y z properties only