Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[external] update globjects and glm. #1016

Merged
merged 20 commits into from
Oct 26, 2022

Conversation

dlyr
Copy link
Contributor

@dlyr dlyr commented Oct 20, 2022

Pull Request Desription

Check if you branch history is PR compatible

  • The commit message follows our guidelines

  • Tests for the changes have been added (for bug fixes / features)

  • Docs have been added / updated (for bug fixes / features)

  • What kind of change does this PR introduce?

    • bug fix
    • feature
    • docs update
    • other: update externals

This PR update globjects back to its upstream repo instead of my fork, since eigen support has been merged.
But it need also updated version of glm and glbindings.

TODO:

  • remove deprecated patches
  • update reference to externals in doc

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #1016 (6bdcc74) into release-candidate (a2a8f7c) will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           release-candidate    #1016   +/-   ##
==================================================
  Coverage              43.99%   43.99%           
==================================================
  Files                    335      335           
  Lines                  22364    22364           
==================================================
  Hits                    9838     9838           
  Misses                 12526    12526           
Impacted Files Coverage Δ
src/Core/Asset/Camera.cpp 96.80% <ø> (ø)
src/Engine/Data/EnvironmentTexture.cpp 72.88% <ø> (ø)
src/Engine/Data/TextureManager.cpp 6.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dlyr dlyr closed this Oct 23, 2022
@dlyr dlyr reopened this Oct 23, 2022
@dlyr dlyr force-pushed the updateExternals branch 4 times, most recently from 284acbc to f69395a Compare October 24, 2022 18:58
@dlyr dlyr mentioned this pull request Oct 25, 2022
5 tasks
Copy link
Contributor

@MathiasPaulin MathiasPaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for me and I agree to merge.
I check the remove deprecated patches TODO
BTW, I did not approve yet as it remains a TODO but what do you means by update reference to externals in doc ?

@dlyr
Copy link
Contributor Author

dlyr commented Oct 25, 2022

Seems fine for me and I agree to merge. I check the remove deprecated patches TODO BTW, I did not approve yet as it remains a TODO but what do you means by update reference to externals in doc ?

I mean what shown in 6bdcc74

@nmellado nmellado merged commit 00a25fc into STORM-IRIT:release-candidate Oct 26, 2022
@nmellado nmellado deleted the updateExternals branch October 26, 2022 12:52
ntsh-oni pushed a commit to ntsh-oni/Radium-Engine that referenced this pull request Jan 24, 2024
[external] update globjects and glm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants