-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[external] update globjects and glm. #1016
Conversation
Codecov Report
@@ Coverage Diff @@
## release-candidate #1016 +/- ##
==================================================
Coverage 43.99% 43.99%
==================================================
Files 335 335
Lines 22364 22364
==================================================
Hits 9838 9838
Misses 12526 12526
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…nals installation directories
Fix cmake --install . --prefix for README.md and LICENSE.
284acbc
to
f69395a
Compare
Since its scoped variable, no need to pop for parent scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine for me and I agree to merge.
I check the remove deprecated patches
TODO
BTW, I did not approve yet as it remains a TODO but what do you means by update reference to externals in doc
?
I mean what shown in 6bdcc74 |
[external] update globjects and glm.
Pull Request Desription
Check if you branch history is PR compatible
The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce?
This PR update globjects back to its upstream repo instead of my fork, since eigen support has been merged.
But it need also updated version of glm and glbindings.
TODO: