-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update exception_list.hpp #6568
base: master
Are you sure you want to change the base?
Conversation
This exception_list class in the hpx namespace is a thread-safe container for handling multiple exceptions encountered during parallel algorithm execution. It allows storing std::exception_ptr objects, provides thread-safe access via a spinlock, and includes methods to add exceptions, get the count (size()), and iterate over the stored exceptions (begin()/end()). The class also includes placeholders for retrieving error codes and messages. This is useful for collecting and managing exceptions across parallel threads.
Can one of the admins verify this patch? |
@charan-003 two questions:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
@hkaiser Could someone help me debug the CircleCI errors (build-and-test, clang_format, core, depreport, and inspect) on this pull request? Thank you! |
You have to log in to circleci using your github credentials to see the logs there. |
This exception_list class in the hpx namespace is a thread-safe container for handling multiple exceptions encountered during parallel algorithm execution. It allows storing std::exception_ptr objects, provides thread-safe access via a spinlock, and includes methods to add exceptions, get the count (size()), and iterate over the stored exceptions (begin()/end()). The class also includes placeholders for retrieving error codes and messages. This is useful for collecting and managing exceptions across parallel threads.
Fixes # [Issue Number]
Proposed Changes
Added exception_list class for managing exceptions in parallel execution
Implemented thread-safe methods for adding and accessing exceptions
Provided placeholders for error code and message retrieval
Any background context you want to provide?
This class addresses the need for managing multiple exceptions in parallel algorithms and ensures thread safety via hpx::spinlock. It simplifies exception handling in concurrent contexts.
Checklist
Not all points below apply to all pull requests.
I have added a new feature and have added tests to go along with it.
I have fixed a bug and have added a regression test.
I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.