[WIP] Basic Gym support (without fighting)

[jakubsuchybio]

Closes issues

• Closes Gyms and battles #1669
• Closes Gym lvl 0 (without any team) is not visible on the map #1744

Changes

• Refactored TeamColor in conventer
• Add missing data to the GymPageViewModel
• Wire up basic data (GymLevel, GymMaxPoints)
• Wire up List of pokemon and trainers data in the gym with FlipView navigation
• Wire up Deploy Pokemon button with selection of pokemon and confirmation dialog
• Wire up Start battle button with message dialog with "Not implemented"
• Wire up SetPlayerTeam when Player have no team and he have >=5 Lvl with 2 MessageDialogs to choose a team and to confirm his choice

Other info

Look on the map:

Look inside the gym:

[WavingLawyer644]

this is cool that you got the pokemon Gym on the map and the Gym ready

[Jehu147]

Well thats amazing

[Rover656]

Great work!

[dvnjhn]

when does this update be available..!?

[Lavince]

@dvnjhn whenever they finish it.

[WodsonKun]

I can help with some images (Team Icons on Map, Plataforms, Fonts for Pokémon Name, etc...)

[vossik]

It look so nice^^
Vypadá to skvěle, dobrá práce :)

[jakubsuchybio]

Dik, ale uprimne ja ten design nedelal :D. Na tej mape uz to existovalo jenom se to nezobrazovalo. A tadytu stranku delal Mr. khunpanya. Ten zaslouzi kredit za design. Ja to jenom napojuju na API a aby to vsechno fungovalo.

[jakubsuchybio]

Guys, do not freak out with @swisszeni commits. I just merged into this branch in my fork his PR, because I need it for my DeployButton wiring. After his PR gets merged I will rebase this and it won't be such a mess anymore.

[jakubsuchybio]

A little update:

There are some differences against official app. For example:
The crown should appear only on highest CP pokemon and also on top of the top dot indicator.
These dot indicators look correct, but when there is lvl 5 gym with only 3 pokemon, it will show only 3 indicators. It should show 5 indicators with first 2 blank and 3 occupied.

I will leave these flaws for some future touches by some UI guys.

One question though.
Can someone tell me what that Battles Won means? Is it for the pokemon how much it defended? Is it for the player how much he/she won?

[Rover656]

This designated how many battles this Pokémon has won. In other words how many times it has successfully defended an attacker.
For further clarification, based on personal experience, I have only seen it pop up for Pokémon that took down my last Pokémon in my party when I was attacking a gym.

Source: http://gaming.stackexchange.com/questions/277731/what-does-battles-won-refer-to

[ST-Apps]

@jakubsuchybio just merged the other one, waiting for rebase.

[jakubsuchybio]

Ok so today I made some field testing.

• When gym is empty you can deploy first pokemon with Pogo just fine, just getting into the empty gym is a little hard because of Gym lvl 0 (without any team) is not visible on the map #1744
• When gym is not empty and it is the same team as you are, you can also deploy pokemon just fine

All deploying was done by automatic selection via LINQ of highest favorite CP pokemon, that is deployable (has full health, is not deployed yet and is not a buddy)

For manual deployment I am waiting for @swisszeni until he implements Pokemon Selection from Pokemon Inventory, because he made new pokemon inventory and is also implementing this.

[programmer135]

It showed no issues in the checker but this code is good
In my opinion.

[jakubsuchybio]

• Merged @khunpanya fixes for battles won, some bad light colors, other UI fixes for better scaling
• Rebased to latest master

Now only the pokemon deployment is missing. Or should I make a dialog with Ok/Cancel where I ask user if he wants to deploy his highest CP favorite available pokemon? If OK, then deploy, if Cancel, then nothing?

[Rover656]

@jakubsuchybio sounds like a good idea

[adrianekk955]

I have a little question, how can i test it?

[jakubsuchybio]

This is not a forum. This is easy GitHub task, if you don't know it ask at Reddit or Discord

[LuckysSeX]

Nice job guys! :)
Dobrá práce kluci nevěděl jsem,že mezi vývojáře patří i češi :)