New PoGo Loading Screen #1429
New PoGo Loading Screen #1429
Conversation
|
Niceeeee - |
|
What about putting a picture (loading screen) under your designed loadingbar |
|
@robipzo What Picture do you mean? The PoGo Icon or another Image? |
|
Another image like the original loadscreen from android @Markusch85 |
|
@Markusch85 I'm not sure if we can use the original ones but there were postet some nice picture with a text (like look surround you idk) on github. I cant find them maybe you can |
|
And not the PoGo icon as i said a pokemon picture with a text(look surround you etc).I think you know what i mean |
|
I want a appx haah :D |
|
Hey @Markusch85 could you join forces with @swisszeni ? He is already working on something similar for 2.0 on new repo, but I think it could be even brought into 1.1 |
|
@Markusch85 nice work! |
|
@MedaiP90 Thank you. Later I'll try to implement a nice loading Screen a upload a screenshot here. |
|
Hey guys. Here is another Screenshot of a complete new Loading Screen. What do you mean? |
|
Its very nice :) |
|
Wow! Nice job @Markusch85 Markusch85 very good same , only a idea, I saw that the @viniciusbrasil put some images of loading screen also, you could put in form of "slides" while loads. Well, only a ideia, nothing of important :) |
|
@RigleyC Thank you. I've implemented a random logic, which is able to choose an image with the correct description. I haven't found the images from @viniciusbrasil without text. So, I didn't add them. If I'll find these images without text, I'll add them. The case is, that we have to translate the texts. |
|
@Markusch85 So, with " without text" you wanna say "without text of alerts"? |
|
Nice work! Every picture is nice but I think its the best to use the original one.Just to come as close as possible to niantic version :) |
|
@RigleyC That's the right direction. ;) |
|
Hey @Markusch85 What do you think? The resolution are good? |
|
Have more one without text |
|
You cant just put a box dialog message overlaping the text |
|
? |
|
Thank you guys. Here is the next Screen. |
|
@viniciusbrasil I can do it, but it seems like a hack. If we have more clean Images without any text, we are more flexible. |
|
@skyne Thanks for finding the typo. ;) @RigleyC Hey, can you change the Image Warnings/1.png? It's the second posted Image from me. That wood be nice. |
|
|
||
| namespace PokemonGo_UWP.Views | ||
| { | ||
| public sealed partial class InfoMessage : UserControl |
There was a problem hiding this comment.
Where is this class ever used?
|
@swisszeni Sorry, this was the first loading message popup (first screenshot). I Forget to remove it. @ALL Thanks for checking the code. The will be cleaner if somebody will review it. |
|
@Markusch85 The image of "Gyarados"? To remove box and the text? |
|
@RigleyC Thank you again. ;) Otherwise, I've only found the next Image: |
|
Hm.. Personally, I don't think we should add custom loading screens. There's no "official" translation and localisation (or rather, reliably translating the meaning) might be a problem. For example, "Try to not smoke in crowds. Nobody likes to breathe Koffing fumes" can hardly be accurate since smokers obviously want to smoke (otherwise they wouldn't be smokers). Now I'm sure you meant something along the lines of "Not everyone wants to inhale Koffing fumes", but we'd have to check every PR and every translation of custom lines for those small mistakes and errors that can be made in translation. I just don't think we have the manpower (or fluency in all those languages) necessary for that, even if it's just a relatively small feature now. About the dialog box/information at the top of the screen.. @swisszeni is currently working on a refactor of the message box system for a future release here, which has been mentioned before in this thread. It's going to look like the one in the official app from what I've seen of it, so remaking it now seems redundant (especially since he'd have to incorporate/refactor your changes as well). In the end, it's @ST-Apps' decision, those are just my two cents about this. |
|
Yeah, I think you're right.We should just use the official Screens. I have no Pokémon Go for Android or iOS, so I don't know what loading Screens there are. I thougt That are all the Images I've got from the community. I'll revert the Images and add only the original one. About the Dialog: I've removed the Control, because I don't use it. That was only the first new Loading message. Now it's the full Screen loading message. @Seelengrab Thanks for your opinion. @RigleyC Sorry for your work, which won't be in the PoGo App. I know that you've spent much time to remove the Texts and boxes. But I think we should use only the original one. Than the App will be like the Android or iOS App. |
|
No problem. Having custom loading screens and all that stuff isn't out of the question though, it's just not a priority right now and would add more work than it's worth at the moment :) So maybe (possibly, not certainly!) it'll be in at a later date. Alright, once you've removed the images and changed the necessary parts of your code, please update the original post of the PR to be representative of the current status of the PR and what it looks like. After that, I think it's good to go. |
|
I've reverted the custom images an Messages. Here is the latest screenshot. The original post is updated. |
|
Alright, apart from the still distorted image, LGTM. |
|
I know the image has not the best resolution, but that's the only image I've found. It's from the Pokemon-GO-App-Assets-and-Images Folder in this repository. |
|
@Markusch85 Oh, all right at least we have the images, I hope can be implemented one day. :) |
|
Great work! |
|
@FloMoTionGo If you want to install latest official release goto http://github.com/ST-Apps/PoGo-UWP/releases and if you want to compile a bleeding-edge version download the repo using the green button on home page and follow instructions of dev wiki to get up and running. |
|
|
|
There is a re-implementation of the message infos (e.g. your GPS message) in progress. So, another developer will add these feature in the future |
|
It's not really that easy tho tbh is it @Rover656 I think people shouldn't try if they aren't a dev I tried but I'm not gonna pretend I understand because if I try a bleeding-edge install it may do something really bad and I'll be a total noob and "turn it off and on again" |
|
Please keep discussion relevant to the issue. Off-topic discussion or discussion related to another issue/feature request is best done in the respective issue, discord or the subreddit. |
|
i love the new loading screens |
|
Nice PR! |
|
Start screen customizable, add all images and add settings for custom start screen |
|
Add the pokemon loading screen music to finish it off:- |
Closes issues
Closes #1406Changes
Change details
I've added a new Control as loading Screen which is like the original one. You're able to set a custom loading message to the screen.
Other informations
It's the latest Version of the new loading Screen. There is only one Image and message (like the original one)
Here is a Screenshot