provision: make playbooks work on virtual machines in idm-ci #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-vavra-cz
force-pushed
the
mod4vms
branch
13 times, most recently
from
f2f06bf
to
825fe12
Compare
jakub-vavra-cz
changed the title
jakub-vavra-cz
force-pushed
the
mod4vms
branch
4 times, most recently
from
0d816bd
to
9b4cb94
Compare
pbrezina
reviewed
Feb 9, 2023
jakub-vavra-cz
force-pushed
the
mod4vms
branch
8 times, most recently
from
a0b8a73
to
7dba144
Compare
jakub-vavra-cz
force-pushed
the
mod4vms
branch
3 times, most recently
from
012eaf1
to
6c818b6
Compare
jakub-vavra-cz
force-pushed
the
mod4vms
branch
11 times, most recently
from
8a7d88b
to
e26148f
Compare
ikerexxe
approved these changes
Jul 20, 2023
|
I will review this on Monday, can you please rebase it in the mean time? |
pbrezina
requested changes
Jul 24, 2023
There was a problem hiding this comment.
Hi, looks good to me, there are few minor comments.
Now, it would be good, if you can approve #51 before we merge this one and incorporate it into this pull request so passkey testing functionality is always built. It moves the bits into stand alone rpm package so build dependencies are no longer required to be installed.
I'm running the provisioning also locally so I can check that all existing tests pass. I'll get back with results.
| @@ -0,0 +1,6 @@ | |||
| - name: Enable idm module | |||
| command: yum module enable idm:DL1 -y | |||
| when: ansible_distribution_major_version == '8' | |||
There was a problem hiding this comment.
It is needed after all on rhel 9, returned it back:
fatal: [master.ipa.test]: FAILED! => changed=true
cmd:
- yum
- module
- enable
- idm:DL1
- -y
delta: '0:00:02.163913'
end: '2023-07-25 06:13:18.094871'
msg: non-zero return code
rc: 1
start: '2023-07-25 06:13:15.930958'
stderr: |-
Error: Problems in request:
missing groups or modules: idm:DL1
stderr_lines: <omitted>
stdout: |-
rhel-9.3 buildroot 57 MB/s | 3.6 MB 00:00
rhel-9.3 buildroot debuginfo 56 MB/s | 2.5 MB 00:00
stdout_lines: <omitted>
1378856
to
37c0a45
Compare
pbrezina
requested changes
Jul 24, 2023
jakub-vavra-cz
changed the title
Create playbook_vm.yml to include image_base and image_service to work on VM with become. Change the ci user UID locally so it does not collide with cloud-user and fedora user. Modify packages role so it recognizes rhel and applies pieces on appropriate host groups. Replace freeipa with ipa for RHEL. Improve ldap and ipa task idempotency. Add a dns role to configure dns VM. Allow appending to authorized keys instead of rewriting. Add a ssh host key for dns. Add retries to restarting ssh service as it seems to be flaky. Skip passkey on VMs (As it adds unwanted build dependencies). Modify AD role to reuse on VMs without vagrant. Make the backends ipa, ldap, samba optional. Make realm join verbose.
pbrezina
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create playbook_vm.yml to include image_base and image_service to work on VM with become.
Modify packages role so it recognizes rhel and applies pieces on appropriate host groups.
Replace freeipa with ipa for RHEL.
Improve ldap and ipa task idempotency.