Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chameleon Storage Concealment Implant effect rework #1213

Merged

Conversation

LeDrascol
Copy link

About The Pull Request

This PR updates the Chameleon Storage Concealment implant with a few minor features.

  • Fake sparks are replaced by telekinesis sparkles
  • Spark sound is replaced by a subtle woosh
  • Chat messages now indicate what item is worn
  • Toggling has a one second cooldown to prevent spam
  • No effect or message is generated without a back item

LizardSparkle
Sparkle effect.

Why It's Good For The Game

The existing implementation of this implant was designed with placeholder effects that do not adequately represent it. Sparks should not be created by a 'weak psychic signal'. The lack of a cooldown could also lead to unwanted causes of particle effect and sound spam.

A Port?

No.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
tweak: Storage Concealment implant uses new SFX
tweak: Storage Concealment implant now has a one-second cooldown
tweak: Storage Concealment implant chat messages now display what you're wearing
tweak: Storage Concealment implant will not produce SFX without a back item
/:cl:

Updates the Chameleon Storage Concealment Implant.
- More subtle effect
- Dynamic messages based on the item worn
- One second cooldown
@MosleyTheMalO MosleyTheMalO merged commit 91d353d into SPLURT-Station:master Oct 30, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants