Fix shuttle_catastrophe canSpawnEvent #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Prevents the shuttle_catastrophe event from occurring when the build your own shuttle is selected.
This was already intended to be the case, but the existing code failed to work due to relying on a name that wasn't actually used. This changes it to check the type instead, since the BYOS has its own subtype.
Why It's Good For The Game
The build your own shuttle takes a long time to construct well. With the shuttle catastrophe occurring, it undoes hours of work,
and in fact makes it impossible to recover or even restart that work in the same shift. It also has problems on top of that, leading to the shuttle sometimes simply not existing or killing everyone.
Without this, it's practically impossible to make a BYOS that actually works, without an admin disabling events altogether.
A Port?
Nope.
Pre-Merge Checklist
Changelog
🆑
fix: Code disabling the shuttle_catastrophe event while a BYOS is active.
/:cl: