Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CogStation Remake #1175

Merged
merged 35 commits into from
Oct 24, 2024
Merged

CogStation Remake #1175

merged 35 commits into from
Oct 24, 2024

Conversation

JWosak
Copy link

@JWosak JWosak commented Jun 30, 2024

About The Pull Request

Remake of Cogmap 1 built to fit the server and look like other maps in rotation like BoxStation, DeltaStation, MetaStation while combining designs of multiple Goonstation maps such as: Cogmap 1, Cogmap 2, Oshan Laboaratory, Kondaru, expands on departments and maintenance with a lot of QOL with a lot of buttons and shutters.

Note: I have play tested this map many times and i haven't found anything to correct, so this should be finished product, but i might have missed something, this map will still get active updates and corrections upon found problems.

Why It's Good For The Game

Due to current CogStation version being old Goonstation version of map, I have updated it to current Cogmap 1 version and then modified it to fit the server. People who playtested it and looked over the screenshots gave mostly positive reviews that it is better and looks better too, only part that some peole did not like was kitchen and botany being too far, but that is very similar to original and i had no idea how to change it to better without compromising looks. I put a lot of time into decals and details to try give the map more life than being just gray floor. Screenshots trough development can be found on mapping channel on Discord, if you cannot find such thing then you are on wrong Discord server or this is PR to wrong codebase,

A Port?

"Cogmap 1" (Goonstation)

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes. (Too many changes for them all to be documented)

Changelog

🆑
del:

  • CogStation

add:

  • CogStation
  • Ai Laws Conf.mark included
  • Designation Tag Conf.mark included

tweak:

  • Perma is now perma + genpop

  • Atmos moved

  • Supply and Scrubbers network now use layers

  • Engineering moved

  • Engine is now SM

  • Cargo moved

  • T-comms moved

  • AI sat has been merged with science

  • Robotics moved

  • Blueshield office is now connected to bridge

fix:

  • Turbine now has console

expansion:

  • Expanded dorms

qol:

  • Added more privacy shutters

/:cl:

Copy link

@MosleyTheMalO MosleyTheMalO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please save your map in TGM format using SDMM, and install the git hooks in tools/hooks/install.bat

@JWosak
Copy link
Author

JWosak commented Jul 2, 2024

Please save your map in TGM format using SDMM, and install the git hooks in tools/hooks/install.bat

File should now be in TGM format, as for git hooks, I had no idea how to proceed with that, so I downloaded newest version and installed it and then opened tgstataion.dme in SDMM and did changes in file

@JWosak JWosak requested a review from MosleyTheMalO July 2, 2024 00:43
@MosleyTheMalO
Copy link

File should now be in TGM format, as for git hooks, I had no idea how to proceed with that, so I downloaded newest version and installed it and then opened tgstataion.dme in SDMM and did changes in file

Just go in your pc to the folder I mentioned in the repo and run install.bat

@JWosak
Copy link
Author

JWosak commented Jul 2, 2024

File should now be in TGM format, as for git hooks, I had no idea how to proceed with that, so I downloaded newest version and installed it and then opened tgstataion.dme in SDMM and did changes in file

Just go in your pc to the folder I mentioned in the repo and run install.bat

I did, Linters finished with warning

@JWosak
Copy link
Author

JWosak commented Jul 2, 2024

These last few updates are for something i missed, should pass all checks again, on other note, last time there were warnings about Node.js 16 actions being deprecated and to update them to use Node.js 20 actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3

It appears to be asking to update workflow to use v4 actions?

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Deployed

Details
Server Instance

SPLURT

Revision

Origin: 6075554
Pull Request: 4edeca7
Server: 45129974f5808553774218b44c0c2edf7261f7ff

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: e6cee91
Pull Request: 4edeca7
Server: d68d9b817b52f1fb6ba3056c973b4d8bfcb5e97a

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: e6cee91
Pull Request: e20aa2b
Server: e0e4d07da07f269dd16d55e3ef0d35b26f69d066

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 2e30a9b
Pull Request: e20aa2b
Server: d06fa33654dd2324e8e8d0d0da898415041904ad

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: e08a897
Pull Request: e20aa2b
Server: 1810694ab6f9d55d802a7994603a8cd50a2832a3

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 70b0255
Pull Request: e20aa2b
Server: 41c90a8a0314a644a1364ef38d3ce06c66c10b28

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 70b0255
Pull Request: e20aa2b
Server: 0f2ce0f216be5d25663a120a7614c56a999f88ef

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 70b0255
Pull Request: e20aa2b
Server: a265e600c71b5b6ba2d9ebf7c2469ba8517e6592

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 6ab0655
Pull Request: e20aa2b
Server: 6636718e78ffecef9d732975017ba53856651a88

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 91a0b89
Pull Request: e20aa2b
Server: 003d2a8415c376ee4cf376e1fb60bbe75bc571f7

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 91a0b89
Pull Request: b56283c
Server: aae2d113882170a1e4bc4477ce32926c69ff2f04

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 91a0b89
Pull Request: b56283c
Server: 06ee37678a6cd41a91e8e1f26e8d7d16726ef927

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: aab35fb
Pull Request: b56283c
Server: 5b6ba4decbf9e3949e7b7ae5e2e86d044a1e83c6

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: c0f7c47
Pull Request: b56283c
Server: d4f57bece99931bbee1747b20a96ec56dc728b26

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Updated

Details
Server Instance

SPLURT

Revision

Origin: 1802542
Pull Request: b56283c
Server: 74ada8639f89a6820d46a3d0f2953b9630ca27b7

Comment

@SPLURT-Station-Bot
Copy link
Collaborator

Test Merge Removed

@MosleyTheMalO MosleyTheMalO merged commit 30d1b15 into SPLURT-Station:master Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants